Fix babel-runtime Map predicate#289
Open
sellimenes wants to merge 1 commit into
Open
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
babel-runtime/core-js/mapMap instances as Maps in the flow-runtime built-in Map predicate.instanceof Mapbehavior, while also accepting values branded as[object Map]so Babel transform-runtime class property defaults do not fail withExpected: Map / Actual: Map.babel-runtime/core-js/mapwithMap<string, number>.Fixes #177
IssueHunt bounty: https://oss.issuehunt.io/r/gajus/flow-runtime/issues/177
Testing
yarn install --frozen-lockfile --ignore-scripts(used because the repo's oldnode-sasspostinstall fails on Node 24/Python2)yarn --cwd packages/flow-runtime test --grep "babel-runtime Map"yarn --cwd packages/flow-runtime testgit diff --checkNotes
yarn --cwd packages/flow-runtime lintstill fails on existing fixture semicolon errors and missingjsx-a11y/alt-textrule warnings unrelated to this change. Linting only the touched files exits 0 with existing warnings.