Fix class property refs for transformed builtins#286
Open
dicnunz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177.\n\nIssueHunt bounty: https://oss.issuehunt.io/r/gajus/flow-runtime/issues/177\n\n## What changed\n- Emits class-property decorator refs for built-in runtime constructors (Date, Map, Promise, Set) as value references instead of string references.\n- This lets downstream Babel transforms such as transform-runtime rewrite Map/Set/etc. consistently with the class property initializer.\n- Adds a regression fixture for Map class properties.\n\n## Tested\n- TEST_FILTER=177-map-class-property-transform-runtime yarn --cwd packages/babel-plugin-flow-runtime test\n- yarn --cwd packages/babel-plugin-flow-runtime test\n- yarn --cwd packages/babel-plugin-flow-runtime lint (passes with existing missing jsx-a11y/alt-text warnings)\n- git diff --check
IssueHunt Summary
Referenced issues
This pull request has been submitted to: