Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support, Demo files and separate italic theme #21

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tobiastimm
Copy link

@tobiastimm tobiastimm commented May 9, 2018

In my last PR #5 I've added TypeScript support to subliminal.

In this PR I have done some refactoring

  • TypeScript .ts / .tsx support
  • Preserved the original Subliminal theme
  • Reformatted the long selection strings to arrays
  • Separated some scopes into language groups (would enable different colors for different languages)
  • Added extra theme for more italic / operator style
  • Added demo files

TypeScript before
ts before

TypeScript after
ts before

The screens are based on the Subliminal Operator theme. In the original theme the italic style style is kept to a minimum.

Fixes #19 #4

EDIT:

  • Improved TypeScript colors
  • HTML Support

TypeScript ts / tsx
subliminal-actual-tsx

HTML before
subliminal_html_before

HTML after
subliminal_html_after

@tobiastimm tobiastimm mentioned this pull request May 9, 2018
@tobiastimm
Copy link
Author

@gaearon @palashmon

Would be cool if one of you guys could review it 😄

@palashmon
Copy link
Contributor

Looks good to me 👍

@tobiastimm
Copy link
Author

@gaearon Hey Dan, any chance that we can merge this for TypeScript support?

@adriantoine
Copy link

That would be great, is there a way to test this specific branch locally?

@tobiastimm
Copy link
Author

@adriantoine you can clone my fork via git into your .vscode/extensions folder. Make sure to uninstall your subliminal version first

@adriantoine
Copy link

@tobiastimm well I ended up using your theme Raiju, thanks!

@GlennSmeulders
Copy link

GlennSmeulders commented Jun 12, 2018

Very nice, thank you @tobiastimm

EDIT: @tobiastimm would it be possible to add a color for type assignment perhaps?

For example: ids: string[] so we highlight string[]

@tobiastimm
Copy link
Author

@GlennSmeulders sry I'm not working on this anymore :/

@tobiastimm
Copy link
Author

@GlennSmeulders see https://twitter.com/TbsTimm/status/1011895476231262209 . Support also available for the subliminal variant

@andrasnyarai
Copy link

it would be niice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ts files
5 participants