Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added descriptions for AutoComponents #659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added descriptions for AutoComponents #659

wants to merge 1 commit into from

Conversation

MillanWangGadget
Copy link
Contributor

  • UPDATE
    • Added descriptions for AutoComponents exported from the @gadgetinc/react package
    • I left out many of the optional params in the descriptions as I fear they will become foot-guns for the AI
      • Ex: Many AutoInputs re-export onChange from the base Polaris component.
        • When this is overwritten, changing the input value won't include the value in the form submission unless there is some extra code to connect it to the overall form state.
        • If a user gets something like this from the AI, it will be a tough "where is my form value?" bug to fix

@MillanWangGadget MillanWangGadget force-pushed the mill/AddAutoComponentDesriptions branch 3 times, most recently from 378c49a to 70fdb0f Compare October 18, 2024 22:24
@MillanWangGadget MillanWangGadget force-pushed the mill/AddAutoComponentDesriptions branch from 70fdb0f to b3c0665 Compare November 27, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greenlemur greenlemur Awaiting requested review from greenlemur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MillanWangGadget