-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added descriptions for AutoComponents #659
base: main
Are you sure you want to change the base?
Conversation
378c49a
to
70fdb0f
Compare
70fdb0f
to
b3c0665
Compare
@MillanWangGadget this has apparently been sitting in my github for some time lol. Seems super useful for whats about to ship, no? Still need me to review or wanna rebase and rethink it? IMO we should add these descriptions for sure. |
@greenlemur Yeah I can rebase now. I'll need to add some new descriptions for the new relationship forms, but otherwise, things are gonna generally be the same |
b3c0665
to
e69cd5f
Compare
e69cd5f
to
20feb53
Compare
Maybe it makes sense for me to wait until after autocomponents shadcn update and go through every single one when ready? Also, Im just gonna review the content portion so for the other stuff, you might need a different reviewer |
I've updated the Shadcn side to have the same component prop types. Having the component comments with the code snip examples is gonna be a bigger challenge because of how those components are made by passing in user components from their Gadget apps. I think those docs comments may need to be added on the Gadget monorepo side and included in user code by default. As for the content of the Shadcn component docs comments, I think they will be the effectively the same as the ones here for Polaris. I think this is good to review now |
@gadgetinc/react
packageonChange
from the base Polaris component.