Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch and html feature, bugfixes and improvements #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dronakurl
Copy link

Use stylua format, replace vim script, data folder

  • stylua formatter changed a bit of code. The config is included
  • Some autocommand groups where defined in vim script. Converted to lua, for better debugging
  • Fixed all diagnostic messages with lua language server
  • moved the json file from .config to .local folder. Some people want .config to just be their settings (e.g. to include in their dotfiles). A log file should be placed elsewhere. I will make it configurable later
  • added a configuration with optional variables Configuration was previously handled with global variables. It is better to define a configuration that is optional
  • Add configuration option for json file path
  • Added the branch tracking - No aggregation yet [Feature Request] Branch tracking #7
  • fixed wrong port in the telemetry endpoint
  • Better error handling telemetry, select aggregation The error handling for plenary.curl did not work, because it is an async call. plenary.curl documentation is not easy, but I found this feat: add optional on_error callback. fixes #304 nvim-lua/plenary.nvim#471 and included on_error to handle possible errors
  • When the user forgets the aggregation key, a selection is called. As it is vim.ui.select, it should be with the picker of choice
  • plenary test for config
  • html file generation using chart.js
  • doc file

Use stylua format, replace vim script, data folder
- stylua formatter changed a bit of code. The config is included
- Some autocommand groups where defined in vim script. Converted to lua,
  for better debugging
- Fixed all diagnostic messages with lua language server
- moved the json file from .config to .local folder. Some people want
  .config to just be their settings (e.g. to include in their
  dotfiles). A log file should be placed elsewhere. I will make it
  configurable later
- added a configuration with optional variables
  Configuration was previously handled with global variables.
  It is better to define a configuration that is optional
- Add configuration option for json file path
- Added the branch tracking - No aggregation  yet
  gaborvecsei#7
- fixed wrong port in the telemetry endpoint
- Better error handling telemetry, select aggregation
  The error handling for plenary.curl did not work, because it is an async
  call. plenary.curl documentation is not easy, but I found this
  nvim-lua/plenary.nvim#471
  and included on_error to handle possible errors
- When the user forgets the aggregation key, a selection is called.
  As it is vim.ui.select, it should be with the picker of choice
- plenary test for config
- html file generation using chart.js
- doc file
@gaborvecsei
Copy link
Owner

gaborvecsei commented Mar 1, 2024

@Dronakurl thank you very much for the PR! I'll try to review it in the following week - but this is a huge one so it'll take a bit of time. If you can see any features that could be in a separate PR, then it would help if you could separate them.

@Dronakurl
Copy link
Author

OK, I will see to it. I am on some other project right now, though. The html file generation could be separated, I think.

  • I just disabled the plugin in my own environment, because I see these problems you also described in the README. Sometimes, there are periods which are longer than 24h. I think it has something to do with the inactivity detector which does not trigger when I just close my laptop lid or something.
  • I had a look at wakatime.nvim, they use similar techniques, but I could not find out, how they solved this issue (mainly because it is written in vim script). It might even be possible to integrate the possibility to send "heartbeats" to wakatime as an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants