Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding minute_file_sink_mt #2727 #2729

Open
wants to merge 11 commits into
base: v1.x
Choose a base branch
from
Open

Adding minute_file_sink_mt #2727 #2729

wants to merge 11 commits into from

Commits on May 4, 2023

  1. minute_file_sink to support every 1 min file rotation 

    example driver code:
auto logger = spdlog::minute_logger_mt("minutes_basic_logger", "logs/min-log.txt",false,60);
    @mmanoj
    mmanoj committed May 4, 2023
    Configuration menu
    Copy the full SHA
    5306b1f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'gabime:v1.x' into v1.x

    @mmanoj
    mmanoj committed May 4, 2023
    Configuration menu
    Copy the full SHA
    a406f27 View commit details
    Browse the repository at this point in the history

  3. Review fixes 

    Fixes as per suggestions
    @mmanoj
    mmanoj committed May 4, 2023
    Configuration menu
    Copy the full SHA
    9d8efbd View commit details
    Browse the repository at this point in the history

Commits on May 7, 2023

  1. Add files via upload 

    Change the logger name to reflect the minutes interval based rotation and remove the check for max min 59 in configuration.
    @mmanoj
    mmanoj committed May 7, 2023
    Configuration menu
    Copy the full SHA
    464013d View commit details
    Browse the repository at this point in the history

  2. Update check for 0 min configuration check.

    @mmanoj
    mmanoj committed May 7, 2023
    Configuration menu
    Copy the full SHA
    526f938 View commit details
    Browse the repository at this point in the history

  3. corrected as rotation_minute <= 0

    @mmanoj
    mmanoj committed May 7, 2023
    Configuration menu
    Copy the full SHA
    16a9463 View commit details
    Browse the repository at this point in the history

  4. corrected as per suggestions

    @mmanoj
    mmanoj committed May 7, 2023
    Configuration menu
    Copy the full SHA
    9c14149 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Update as per comments 

    Updated as per advice.Please check and update if any changes required.
    @mmanoj
    mmanoj committed May 8, 2023
    Configuration menu
    Copy the full SHA
    715414b View commit details
    Browse the repository at this point in the history

  2. using std::chrono::duration 

    using std::chrono::duration
    @mmanoj
    mmanoj committed May 8, 2023
    Configuration menu
    Copy the full SHA
    74a4eba View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Delete minute_file_sink.h

    @mmanoj
    mmanoj committed May 16, 2023
    Configuration menu
    Copy the full SHA
    86daaf2 View commit details
    Browse the repository at this point in the history

  2. Update as per comments

    @mmanoj
    mmanoj committed May 16, 2023
    Configuration menu
    Copy the full SHA
    b1c1e4d View commit details
    Browse the repository at this point in the history