fix(movie): Close reader to verify gzip checksum is valid

gabe565 · Apr 28, 2024 · cd930bf · cd930bf
1 parent ae135b3
commit cd930bf
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/internal/movie/flags.go b/internal/movie/flags.go
@@ -34,7 +34,7 @@ func FromFlags(flags *flag.FlagSet, path string) (Movie, error) {
 
 	movie := NewMovie()
 
-	var src io.Reader
+	var src io.ReadCloser
 	if path == "" {
 		// Use default embedded movie
 		path = movies.Default
@@ -91,6 +91,10 @@ func FromFlags(flags *flag.FlagSet, path string) (Movie, error) {
 		return movie, err
 	}
 
+	if err := src.Close(); err != nil {
+		return movie, err
+	}
+
 	log.Info().
 		Str("duration", movie.Duration().Round(time.Second).String()).
 		Str("took", time.Since(start).Round(time.Microsecond).String()).