lint: Add tea.Quit to forbidigo to prevent future memory leaks

gabe565 · Apr 24, 2024 · 6f13e20 · 6f13e20
1 parent 5d0bf46
commit 6f13e20
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -8,6 +8,11 @@ linters-settings:
   gosec:
     excludes:
       - G306
+  forbidigo:
+    forbid:
+      - "^(fmt\\.Print(|f|ln)|print|println)$"
+      - p: "^tea\\.Quit$"
+        msg: tea.Quit may cause a memory leak
 
 linters:
   enable:

diff --git a/internal/movie/player.go b/internal/movie/player.go
@@ -158,7 +158,7 @@ func (p Player) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 		}
 		p.clearTimeouts()
 		p.zone.Close()
-		return p, tea.Quit
+		return p, tea.Quit //nolint:forbidigo
 	case PlayerOption:
 		p.optionViewStale = true
 		return p, p.doPlayerOption(msg)