test: Add test for invalid shell completion value

gabe565 · Aug 28, 2023 · 8032a25 · 8032a25
1 parent 7067afc
commit 8032a25
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/cmd/cmd_test.go b/cmd/cmd_test.go
@@ -158,15 +158,25 @@ func TestSBCEnvs(t *testing.T) {
 }
 
 func TestCompletionFlag(t *testing.T) {
-	for _, shell := range []string{"bash", "zsh", "fish", "powershell"} {
-		t.Run(shell, func(t *testing.T) {
+	tests := []struct {
+		shell        string
+		errAssertion assert.ErrorAssertionFunc
+	}{
+		{"bash", assert.NoError},
+		{"zsh", assert.NoError},
+		{"fish", assert.NoError},
+		{"powershell", assert.NoError},
+		{"invalid", assert.Error},
+	}
+	for _, tt := range tests {
+		t.Run(tt.shell, func(t *testing.T) {
 			cmd := NewCommand("", "")
-			cmd.SetArgs([]string{"--completion", shell})
+			cmd.SetArgs([]string{"--completion", tt.shell})
 
 			var buf bytes.Buffer
 			cmd.SetOut(&buf)
 
-			if err := cmd.Execute(); !assert.NoError(t, err) {
+			if err := cmd.Execute(); !tt.errAssertion(t, err) {
 				return
 			}