Don't auto-load default maps #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the plugin was loading, it was setting the default maps for every buffer whether an audio file had been loaded with TranscibeAudio or not so that typing, for example, <C-l> in insert mode would insert the text "<plug>(transcribe-seek-forward)" literally. Worse, because the default mappings map <C-h>, loading the plugin rendered the backspace key inoperative for any terminal that sends backspace as ^H. This changeset causes the default mappings to be set only the first time :TranscribeAudio is used per buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the plugin loads it was setting the default maps for every
buffer whether an audio file had been loaded with TranscibeAudio or not
so that typing, for example, in insert mode would insert the text "(transcribe-seek-forward)" literally.
Worse, because the default mappings map , loading the plugin
rendered the backspace key inoperative for any terminal that sends
backspace as ^H.
This changeset causes the default mappings to be set only the first time :TranscribeAudio is used per buffer. It is how I've fixed things for my setup for now, but there may be a more standard way of handling plugin default mappings.