source emoji from unicode.org html file; add emoji category #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For diacritics handling, you may want to use sanette/ubase. It may not fix everything (I see you had to replace |
zapashcanon
reviewed
Dec 27, 2022
zapashcanon
reviewed
Dec 27, 2022
| (* leading ints are illegal in | ||
| * OCaml identifiers so we prepend | ||
| * them with a '_' *) | ||
| let wrap_leading_ints s = match s.[0] with '0' .. '9' -> "_" ^ s | _ -> s |
There was a problem hiding this comment.
I would rather match on anything that is a valid identifier, and if it's not the case, then, add a _
zapashcanon
reviewed
Dec 27, 2022
zapashcanon
reviewed
Dec 27, 2022
zapashcanon
reviewed
Dec 27, 2022
zapashcanon
reviewed
Dec 27, 2022
|
This is now updated to unicode v15.1 🐦🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code to generate emoji.ml parse html files from unicode.org: http://www.unicode.org/emoji/charts/full-emoji-list.html and https://www.unicode.org/emoji/charts/full-emoji-modifiers.html
It has all emojis according to https://www.unicode.org/emoji/charts/emoji-counts.html
It add diacritics fixes.
It add (sub)categories!
It add tests, and various changes, update readme.md
It conflict with the lasts two commits since those changes are based on before @favonia change to gencode.ml
but the only real conflict is how diacritics are handled. In this PR we only use '_' to replace diacritics to stay consistent and stay as close as possible to the official names.