generated from future4code/pokedex-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR de Correção #19
Open
leticia-chijo
wants to merge
47
commits into
correcao-projeto
Choose a base branch
from
master
base: correcao-projeto
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PR de Correção #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[criação do app] comentário no App.js
Parte header e router segunda-feira
Componentes visuais : criação do PokeCard e PokeImage
resolvendo conflitos
[Todas os componentes visutais dos detalhes do pokemon]
Modifiquei globalState,criei componente Home
…uos que precisamos mapeados
Ajustes na requisição
Feito componente PokeCard,Home,adc Home no Router
…a o nome de acordo com a página
[Aplicação de design] Adicionei cores, apliquei o designer[pokecard, header] , o header muda o nome de acordo com a página
Funcionalidade dos botões Home
Componente Pokedex
ajustes gerais e limpeza de código 1 na HOME
debuggando master e limpeza de código 2 : recuperando pokecard
ajustes pokedex e home. Adicionado função de retira pokecard e adicionar
…de remover pokemons
ajustes finais da pokedex: adicionados alinhamento e correção do bug …
Adocionado toda lógica da página de detalhes + limpeza de código
Limpeza de código geral finalizada. Projeto 100/100
leticia-chijo
commented
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oi gente!
Passando pra dizer que a entrega de vocês foi dentro do esperado, parabéns!
Todos os requisitos obrigatórios do projeto estão funcionando direitinho! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR de Correção