This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Fixes for cli_install script #2654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIOHz0r
force-pushed
the
feature/cli_install
branch
4 times, most recently
from
2735426
to
eb28060
Compare
scripts/cli_install.php
Outdated
| $user->getFromDBbyName($args['--as-user']); | ||
| } else if (is_null($args['--as-user'])) { |
There was a problem hiding this comment.
Why not using else { xxx } instead ?
Regards,
Anael
DIOHz0r
force-pushed
the
feature/cli_install
branch
from
eb28060
to
6a67071
Compare
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/cli_install
branch
from
6a67071
to
be1df49
Compare
DIOHz0r
force-pushed
the
feature/cli_install
branch
13 times, most recently
from
d577775
to
777b04a
Compare
|
I need some help here to understand how the tests work because with the change made some of them are failing, I think the problem is with the hard coded url used on tests, could you review it and give me some advice to solve it?. Thank you. |
DIOHz0r
force-pushed
the
feature/cli_install
branch
2 times, most recently
from
3d0f902
to
67bf471
Compare
Signed-off-by: Domingo Oropeza <[email protected]>
DIOHz0r
force-pushed
the
feature/cli_install
branch
from
67bf471
to
a03bbd3
Compare
|
We have a problem with the tests, they not pass since few days (we think a problem with GLPI code). I will check it in the week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve the installation problems reported in issue #2653