-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add request to response #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevL
force-pushed
the
add-request-to-response
branch
from
February 28, 2024 11:28
bbb6b7b
to
98e3178
Compare
We could pull in #6 as part of this work and the 2.0 release as well. 🤔 |
DevL
force-pushed
the
add-request-to-response
branch
from
February 28, 2024 11:36
98e3178
to
69c6a0b
Compare
DevL
force-pushed
the
add-request-to-response
branch
from
February 28, 2024 14:25
69c6a0b
to
5ac693b
Compare
Co-authored-by: Lennart Fridén <[email protected]>
Co-authored-by: Lennart Fridén <[email protected]>
Co-authored-by: Lennart Fridén <[email protected]>
Co-authored-by: Linus Huzell <[email protected]>
This indicates the potentially breaking changes we're about to implement. Co-authored-by: Linus Huzell <[email protected]>
DevL
force-pushed
the
add-request-to-response
branch
from
February 29, 2024 12:25
5ac693b
to
20ec559
Compare
Co-authored-by: Linus Huzell <[email protected]>
Co-authored-by: Linus Huzell <[email protected]>
Co-authored-by: Lennart Fridén <[email protected]>
Co-authored-by: Lennart Fridén <[email protected]>
Co-authored-by: Lennart Fridén <[email protected]>
This reverts commit 20ec559.
linus-funnel
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Response
objects returned are not associated with thePreparedRequest
triggering them. This PR changes that.In addition, we intend to rework
fake_request
andfake_request_with_response
so that they, just likerequests.request
invokes therequest
method of aSession
object, thus using more of therequests
library.