Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request to response #8

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Add request to response #8

merged 11 commits into from
Feb 29, 2024

Conversation

DevL
Copy link
Contributor

@DevL DevL commented Feb 28, 2024

The Response objects returned are not associated with the PreparedRequest triggering them. This PR changes that.

In addition, we intend to rework fake_request and fake_request_with_response so that they, just like requests.request invokes the request method of a Session object, thus using more of the requests library.

@DevL DevL added the enhancement New feature or request label Feb 28, 2024
@DevL DevL added this to the 2.0 milestone Feb 28, 2024
@DevL
Copy link
Contributor Author

DevL commented Feb 28, 2024

We could pull in #6 as part of this work and the 2.0 release as well. 🤔

@DevL
Copy link
Contributor Author

DevL commented Feb 28, 2024

We should consider implementing support #3 and #4 as part of the 2.0.

linus-funnel and others added 5 commits February 29, 2024 13:23
Co-authored-by: Lennart Fridén <[email protected]>
This indicates the potentially breaking changes we're about to implement.

Co-authored-by: Linus Huzell <[email protected]>
@linus-funnel linus-funnel marked this pull request as ready for review February 29, 2024 14:04
@DevL DevL modified the milestones: 2.0, 1.1 Feb 29, 2024
@linus-funnel linus-funnel merged commit 2fcc726 into master Feb 29, 2024
5 checks passed
@linus-funnel linus-funnel deleted the add-request-to-response branch February 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants