-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement a dialog for importing externally generated tracks from csv #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly stuff we discussed Monday. I updated the file structure a bit to make an import_export folder, and I didn't see any circular import issues when I ran it, but let me know if there is anything weird. I'll keep thinking about how we want to generally handle attributes in a more consistent way too.
src/motile_plugin/import_export/import_external_tracks_dialog.py
Outdated
Show resolved
Hide resolved
src/motile_plugin/import_export/import_external_tracks_dialog.py
Outdated
Show resolved
Hide resolved
src/motile_plugin/import_export/import_external_tracks_dialog.py
Outdated
Show resolved
Hide resolved
…tton in the trackslist
…uess fields and updates the name of the custom attributes when a column is selected
…_tracks instead. Update also view_external_tracks.py and documentation
…dinates does not match with the provided seg_id from the csv file, as this likely indicates that the wrong pair of files has been selected. Remove the warning about viewing tracks that are not a motile run
…nfer the datatypes
Update conda config and pyproject napari entrypoint to tracker
…eg_id was provided
…ze on empty QLineEdit
…age_path_line QLineEdit
… nodes with an empty group attribute)
…anging them to integers and relabeling the segmentation to match the id, if necessary
… area is computed correctly if it is missing at import
… should be calculated
@cmalinmayor Some updates here: I have changed the import code to work with the unique node ids while still allowing importing from a seg that is not labeled by id but by track_id or something else. I also included tests. For export, I switched to the export_tracks function on SolutionTracks. I also made some changes in preparation of having multiple feature measurements (I have this working on a separate branch but I changed it here too even though we only have one measurement (area)). |
@AnniekStok A couple quick notes in addition to my pushed changes (casting the track id to int was the easiest way to fix my numpy float issue):
|
@cmalinmayor Some updates:
I have additional updates on another branch, to allow importing of custom features for viewing in the plot. Maybe we want to merge this in here eventually as well. The example script for importing external tracks still needs to be updated, I will look into that tomorrow and also do some additional tests and checks. |
…udden crash. Use browse button or hit return after typing path to invoke reading csv and populating comboboxes'
… to recompute this value. To be expanded with additional features.
@AnniekStok My "final" reorganization is complete (I think). Some notes:
Otherwise, I mostly moved all the widgets into their own files inside a menus folder, and then split up CSV and Segmentation related functionality into separate pages (the segmentation file browser is now merged with the scaling information page). I did try it with and without a segmentation on the hela example dataset, and also tried importing invalid data/options (selecting 3D for my 2D example). I'll approve this, and then when you get up, you can do a final test and merge if you like it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 😃
…e sends update_buttons signal, this causes the menu to be set to the wrong index and you have to click next twice
Goals for this PR: