Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the RN plugin to receive clicks from JS #92

Merged
merged 7 commits into from
May 31, 2024

Conversation

JoshMiers-FS
Copy link
Contributor

@JoshMiers-FS JoshMiers-FS commented May 9, 2024

This PR adds a new exported module named PrivateInterface. On iOS, no methods are exported. On Android, onFSPressForward is exported.

If this method is called, then we use reflection to find a new (in the upcoming 1.49.0 FS release) FS.reactNative_exec_onFsPressForward_direct method and invoke the press forwarding.

Note: This also changes our minimum supported RN version to 0.66.0.

@JoshMiers-FS JoshMiers-FS force-pushed the joshmiers/react-native-74-updates branch from bb0df64 to 765f3c6 Compare May 14, 2024 22:37
@JoshMiers-FS JoshMiers-FS changed the title [WIP] updated the RN plugin to receive clicks from JS update the RN plugin to receive clicks from JS May 15, 2024
Copy link
Contributor

@RyanCommits RyanCommits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the version dependency of "@fullstory/babel-plugin-react-native" in package.json once we merge the sister PR

Copy link

@ReeceLaF ReeceLaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoshMiers-FS JoshMiers-FS force-pushed the joshmiers/react-native-74-updates branch from 4e00d24 to 2eb7016 Compare May 31, 2024 18:23
@JoshMiers-FS JoshMiers-FS merged commit 742d6fe into master May 31, 2024
6 checks passed
@JoshMiers-FS JoshMiers-FS deleted the joshmiers/react-native-74-updates branch May 31, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants