Fix blank code / message due to wrong variable names #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbranco
force-pushed
the
v3
branch
2 times, most recently
from
bd859cf
to
447108c
Compare
added 2 commits
March 8, 2017 03:36
…r : 'code.toLowerCase not a function'
|
Is there any plans to integrate this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not too familiar with Objective-C however, I was having this issue where createUserWithEmailPassword, was returning code:"" and message:"". While debugging the FirebaseAuth file I noticed the discrepancy in variable names. After refactoring them the error code is shown as expected:
Do let me know if there are any concerns with this change?
Kind Regards
Junio