feat: use OffTargetDetector and ExecutableRunner as ContextManagers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintval
commented
Oct 4, 2024
Comment on lines
+588
to
+597
| picked: list[PrimerPair] = pick_top_primer_pairs( | ||
| primer_pairs=primer_pairs, | ||
| num_primers=len(primer_pairs), | ||
| min_difference=min_difference, | ||
| params=params, | ||
| offtarget_detector=offtarget_detector, | ||
| is_dimer_tm_ok=lambda s1, s2: ( | ||
| dimer_checker.duplex_tm(s1=s1, s2=s2) <= params.max_dimer_tm | ||
| ), | ||
| ) |
There was a problem hiding this comment.
This test helper is executed many times. Previously, if any of these tests failed, 100s of file handles would be left open on the OS without close.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 97.37% 97.38%
=======================================
Files 25 25
Lines 1601 1605 +4
Branches 302 302
=======================================
+ Hits 1559 1563 +4
Misses 23 23
Partials 19 19 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
OffTargetDetectorandExecutableRunnerare context managers, it makes sense to type them as such by having them inherit from the abstract manager base class. This PR also fixes an issue where if tests fail, IO resources are not cleaned up since context managers were not being used.