Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change int weights to float weights, update doctest examples #61

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: change int weights to float weights, update doctest examples #61

merged 1 commit into from
Oct 4, 2024

Conversation

emmcauley
Copy link
Collaborator

Closes #59.

@emmcauley emmcauley requested review from nh13 and tfenne as code owners October 3, 2024 19:07
ameynert
ameynert approved these changes Oct 4, 2024
View reviewed changes
Copy link

@ameynert ameynert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emmcauley emmcauley merged commit f71dc65 into main Oct 4, 2024
6 checks passed
@emmcauley emmcauley deleted the em_fix_issue59_primerweights branch October 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameynert ameynert ameynert approved these changes

@tfenne tfenne tfenne approved these changes

@nh13 nh13 Awaiting requested review from nh13 nh13 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: PrimerAndAmpliconWeights should all be floats
3 participants
@emmcauley @tfenne @ameynert