Add check for amplicon size too small.

fulcrumgenomics · Nov 18, 2024 · ebc72f7 · ebc72f7
1 parent f560ff8
commit ebc72f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/prymer/api/picking.py b/prymer/api/picking.py
@@ -143,7 +143,8 @@ def build_primer_pairs(
             for rp in right_primers:
                 amp_span = PrimerPair.calculate_amplicon_span(lp, rp)
 
-                if amp_span.length > amplicon_sizes.max:
+                # Ignore pairings with amplicon sizes out of the range specified
+                if not amplicon_sizes.min <= amp_span.length <= amplicon_sizes.max:
                     continue
 
                 # Since the amplicon span and the region_start are both 1-based, the minuend

diff --git a/tests/api/test_picking.py b/tests/api/test_picking.py
@@ -292,6 +292,7 @@ def test_build_primers_amplicon_size_filtering(
         assert pair.amplicon.end == pair.right_primer.span.end
         assert pair.bases == REF_BASES[pair.amplicon.start - 1 : pair.amplicon.end]
         assert pair.span.length <= 200
+        assert pair.span.length >= 100
 
 
 def test_build_primers_heterodimer_filtering(