This repository was archived by the owner on Jul 22, 2022. It is now read-only.
Add a close button to flash messages#77
Merged
malclocke merged 1 commit intofulcrum-agile:masterfrom Dec 16, 2011
yrb:add_close_button_to_flash_messages
Merged
Add a close button to flash messages#77malclocke merged 1 commit intofulcrum-agile:masterfrom yrb:add_close_button_to_flash_messages
malclocke merged 1 commit intofulcrum-agile:masterfrom
yrb:add_close_button_to_flash_messages
Conversation
|
Hi Bry, Did you close this pull request on purpose? Something wrong with it, or shall I merge it? |
Contributor
Author
|
:) Accidental Click. Though I notice that Greg has opened a feature request to convert the flash messages to use Gritter. Up to you if you would like to merge this in, if is is just going to be replaced. |
|
We'll have it thanks, merged and pushed. Thanks Bry, this fixes a minor but long running annoyance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to dismiss a flash message