-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tui): add Arabic (ar
) locale
#1344
Conversation
6d92d41
to
111e19e
Compare
Thanks @tsallabi you got it. That's perfect thanks. |
bsod_failed: | ||
en: "Trippy Failed :(" | ||
fr: "Trippy a échoué :(" | ||
tr: "Trippy Başarısız :(" | ||
it: "Trippy ha avuto un problema :(" | ||
pt: "Trippy falhou :(" | ||
zh: "Trippy 失败 :(" | ||
ar: "فشل Trippy :(" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
فشل متوقع
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google translate tells me that "فشل متوقع" means "Expected failure" which seems wrong? Also, can you show me how it would look in the full context (i.e. is it "Trippy فشل متوقع :(")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very new word and has different meaning
An adjective meaning cool, freaky, groovy, amazing, or all of the above, depending on the context in which it's used. Although "trippy" is a fairly new word, the root word, "trip," refers to soft psychedelic trips and has been in use since the 60's.
Person 1: "Whoa, dude. Those yellow fractals in the air are pretty trippy..."
Person 2: "Um, I think you've seriously gotta cut the acid. That's the McDonald's sign."
Courtesy: Urban Dictionary: trippy
kilometer: | ||
en: "km" | ||
fr: "km" | ||
tr: "km" | ||
it: "km" | ||
pt: "km" | ||
zh: "公里" | ||
ar: "km" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
كيلومتر
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsallabi which would sound better, "km" or "كيلومتر"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Arabic both are understood, but to be clear كيلومتر is clearer
Thank you @tsallabi will go over it soon and get back to you, really appreciate the help. |
You are welcome There some of them are abbreviation like ttrI had to write full sentences
Yahoo Mail: Search, organise, conquer
|
The space where the abbreviation has to go may not fit the full sentence. Do you think people would understand if we just use the English abbreviation? |
Yes if they work in this filed they should understand it as it will come into sentences
Yahoo Mail: Search, organise, conquer
On Fri, 8 Nov 2024 at 20:34, ***@***.***> wrote:
The space where the abbreviation has to go may not fit the full sentence. Do you think people would understand if we just use the English abbreviation?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
111e19e
to
20ab458
Compare
@tsallabi thanks for your contribution! I've left a couple of questions on the open threads above. Here is is how currently looks: ![]() ![]() ![]() ![]() |
It looks like it doesn't support Arabic language
It should strat from right to left But in the screenshots below it start from left to right So it is wrong
Yahoo Mail: Search, organise, conquer
On Fri, 15 Nov 2024 at 10:41, ***@***.***> wrote:
@tsallabi thanks for your contribution!
I've left a couple of questions on the open threads above.
Here is is how currently looks:
Screenshot.2024-11-15.at.6.39.48.PM.png (view on web)Screenshot.2024-11-15.at.6.39.35.PM.png (view on web)Screenshot.2024-11-15.at.6.39.21.PM.png (view on web)Screenshot.2024-11-15.at.6.39.13.PM.png (view on web)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@tsallabi you are correct. After some research it seems the terminal I am using (iTerm2 on macOS) does not support RTL/BiDi for languages such as Instead, I've taken the approach of reordering the translated text (using a library which supports the Unicode Bidirectional Algorithm) in the application prior to rendering. Below are revised screenshots for ![]() ![]() ![]() These do not match exactly with the desired My question to you is therefore, is the updated rendering better than before and is it right (or at least "good enough")? If not, then it may not be possible to add translations for RTL languages at the moment. |
092f395
to
54dcf56
Compare
54dcf56
to
60256c7
Compare
Closing this as, given the state of RTL support in terminal emulators, Trippy is unlikely to support Arabic for the foreseeable future sadly. Thanks for he help with translating anyway! |
No problem, you are welcome
Yahoo Mail: Search, organise, conquer
On Sat, 25 Jan 2025 at 9:11, ***@***.***> wrote:
Closing this as, given the state of RTL support in terminal emulators, Trippy is unlikely to support Arabic for the foreseeable future sadly. Thanks for he help with translating anyway!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.