Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user defined function call support for MSSQL #781

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MMagueta
Copy link

@MMagueta MMagueta commented Jan 8, 2023

Proposed Changes

WIP

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Further comments

WIP

@MMagueta
Copy link
Author

MMagueta commented Jan 8, 2023

Status:

  • Parse the XML for a scalar function and inline table functions
  • Add callable reference on F#
  • Check parameters for inlined tables and other not so primitive types, such as XML
  • Tests

@MMagueta
Copy link
Author

@JordanMarr I am facing a problem that you might have a field view wider than I do. XML fields are simply not being translated to XElement. A procedure/function/UDDT that has an XML type exposed simply does not get designed, not resulting in an overall failure, the rest continues to work just fine. I did confirm that System.Xml.Linq.XElement is on the map for the TSQL correspondence.
Any ideas of how to assess this?

@JordanMarr
Copy link
Contributor

Is this question related to the SSDT parser?
If so, it might be helpful if you added the sqlproj to the test sln with a broken test to highlight the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants