Upgrade FSharp.Compiler.Service to v43.8.200 to remove workaround in NoPartialFunctions rule #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
changed the title
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
a1ff3e7
to
db33ff6
Compare
|
Even though this doesn't have conflicts, I'd prefer to get a rebase before merging, just to be on the safe side. |
Upgrade FCS to the latest stable version (43.8.200).
Adapte code to changes in FSharp.Compiler.Service.
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
c9f3bd8
to
ee4ecfb
Compare
Rebased. |
|
Can you move the commit |
Fix errors in CyclomaticComplexity tests cause by incorrect indentation of generated code.
Fix bug in tests where empty sets of different types would be treated as different. Error was: ``` Expected is <Microsoft.FSharp.Collections.FSharpSet`1[System.IComparable]>, actual is <Microsoft.FSharp.Collections.FSharpSet`1[System.String]> ```
Upgrade Ionide.ProjInfo.* packages to latest stable (0.63.0) because current version causes bug when running self-check: ``` Lint failed while analysing /home/runner/work/FSharpLint/FSharpLint/FSharpLint.sln. Failed with: Method not found: 'FSharp.Compiler.CodeAnalysis.FSharpReferencedProject FSharp.Compiler.CodeAnalysis.FSharpReferencedProject.CreateFSharp(System.String, FSharp.Compiler.CodeAnalysis.FSharpProjectOptions)'. Stack trace: at [email protected](ProjectOptions p) ... ```
Remove workaround introduced in [1] for bug in FCS [2] that was fixed in FCS 43.8.200. [1] 106be3f [2] dotnet/fsharp#16121
webwarrior-ws
force-pushed
the
remove-nopartialfuncs-workaround-squashed
branch
from
86442cb
to
9e5f360
Compare
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoPartialFunctions needed a workaround because of a bug in FSharp.Compiler.Service library.
In FSharp.Compiler.Service to v43.8.200 that has bug has been fixed.
This PR upgrades FCS to v43.8.200 and makes necessary changes to code. Workaround is removed.
Packages FSharp.Core and Ionide.ProjInfo.* also had to be upgraded to latest stable versions.