Enable more rules for SelfCheck #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
c6b4a7b
to
3f6aada
Compare
knocte
reviewed
Jan 5, 2024
knocte
reviewed
Jan 5, 2024
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
4ca90c9
to
4721598
Compare
knocte
reviewed
Jan 9, 2024
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
76bb3b4
to
66f4229
Compare
knocte
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
3c09d63
to
036c2a8
Compare
|
@Mersho please note I recently did a force-push in this branch. Pull properly to not overwrite my work. After that, you can rebase the branch. |
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
4 times, most recently
from
680b8a1
to
e7e3e00
Compare
knocte
reviewed
Jan 11, 2024
knocte
added a commit
to knocte/FSharpLint
that referenced
this pull request
Jan 13, 2024
…value-squashed" This reverts commit fcf9213 temporarily, because it caused a regression in the rule that we caught when trying to rebase PR fsprojects#668 (it crashes FSharpLint when trying to use FSharpLint on itself).
knocte
reviewed
Jan 15, 2024
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
ccedd44
to
73ad48f
Compare
knocte
reviewed
Jan 15, 2024
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
4 times, most recently
from
b8703f7
to
1e03c5d
Compare
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
0d1c091
to
324085e
Compare
knocte
requested changes
Jan 15, 2024
src/FSharpLint.Core/Rules/Conventions/AvoidSinglePipeOperator.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/FavourStaticEmptyFields.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/RecursiveAsyncFunction.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Formatting/PatternMatchFormatting/PatternMatchClauseIndentation.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Formatting/PatternMatchFormatting/PatternMatchClauseIndentation.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Formatting/Spacing/ModuleDeclSpacing.fs
Outdated
Show resolved
Hide resolved
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
3 times, most recently
from
85e4cf0
to
fca78a4
Compare
Fixing the warning for the FavourTypedIgnore rule:
```
Use a generic type parameter when calling the 'ignore' function.
Error on line 518 starting at column 16
lintWarnings.AddLast warning |> ignore
```
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
e57d4f9
to
1928d4e
Compare
Fixing the warning for FavourStaticEmptyFields rule.
Fixing the warning for FavourConsistentThis rule.
Fixing the warning for AvoidTooShortNames rule.
Fixing the warning for maxNumberOfFunctionParameters rule.
Fixing the warning avoidSinglePipeOperator rule.
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
4368876
to
13e75e7
Compare
Fixing the warning for NoPartialFunctions rule.
Also to use FSharpx.Collections.Seq.tryHeadTail, we must
install and add FSharpx.Collections to our dependencies:
```
Consider using 'FSharpx.Collections.Seq.tryHeadTail' instead of partial function/method 'Array.tail'.
Error on line 126 starting at column 19
|> Array.tail
```
Fixing the warning for MaxLinesInFile rule: ``` ========== Linting C:\Users\PC\source\repos\FSharpLint\src\FSharpLint.Core\Framework\HintParser.fs ========== File suggested to be less than 1001 lines long. Error on line 1001 starting at column 0 ^ See https://fsprojects.github.io/FSharpLint/how-tos/rules/FL0062.html -------------------------------------------------------------------------------- ```
This refactoring activates all rules by default and only deactivates the specified ones.
Mersho
force-pushed
the
Json-RunFsharplintOnItselfTest-Rebased
branch
from
c56b5b6
to
dbf2753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.