DRAFT: Add quick fix to rule82 (multi-fix) #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for suggested quick fix for UsedUnderscorePrefixedElements rule.
Implement quick fix for UsedUnderscorePrefixedElements. Quick fix is only applied if no other identifiers with suggested name (without underscore) exist. There are cases when such identifiers exist, but not in the same scope, and stil no quick fix is applied. Co-authored-by: Mehrshad <[email protected]>
Make ApplyQuickFix method apply all fixes and not only first one. It's necessary when testing rules that can create more than one suggested fix. Co-authored-by: Mehrshad <[email protected]>
webwarrior-ws
force-pushed
the
addQuickFixToRule82
branch
from
fa89efe
to
be6dcb6
Compare
knocte
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement quick fix for
UsedUnderscorePrefixedElementsrule.It renames identifier with
_prefix to identifier without this prefix (e.g._foo->foo).Quick fix is only applied if no other identifiers with suggested name (without underscore) exist.
There are cases when such identifiers exist, but not in the same scope, and still no quick fix is applied. That is because checking the scope proved to be much more difficult than expected.