Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Core.Tests: add new test to AvoidTooShortNames #593

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parhamsaremi
Copy link
Contributor

@parhamsaremi parhamsaremi commented Nov 25, 2022

Closes #592

@parhamsaremi parhamsaremi changed the title Core.Tests: add new test to AvoidTooShortNames DRAFT: add new test to AvoidTooShortNames to Core.Tests Dec 13, 2022
@knocte
Copy link
Collaborator

knocte commented Dec 14, 2022

What's the reason for the PR title & description to not match the commit title and body?

@parhamsaremi
Copy link
Contributor Author

What's the reason for the PR title & description to not match the commit title and body?

Hmm I didn't like how after adding the DRAFT there were two ":" near each other. but when I changed the title, I didn't remember the commit message. I'll change it back.

@parhamsaremi parhamsaremi changed the title DRAFT: add new test to AvoidTooShortNames to Core.Tests DRAFT: Core.Tests: add new test to AvoidTooShortNames Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative for AvoidTooShortNameRule
2 participants