-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncSeq.head and AsyncSeq.tail #154
base: main
Are you sure you want to change the base?
Conversation
4c5571f
to
97e2249
Compare
Isn't Though there's no |
It sure is, it's just a slight inconsistency with non-async collections API (i.e. |
FWIW, |
635f731
to
c2ed6d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Caleb9, sorry for leaving this PR hanging (I wasn't a maintainer yet, at the time). We'll need a few tests, but otherwise this looks good to go in.
I'd understand if you're not around anymore for editing your PR, in which case I can take over and finish it.
@abelbraaksma Should we close this old one out? |
Hello!
Regular
Seq
contains simple convenience functionshead
andtail
. I implemented those forAsyncSeq
, maybe they could be added?Thanks.