Multi transaction API changes #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Nov 9, 2024
README.md
Outdated
|
|
||
| transaction.Check(table, key, doesntExistCondition) | ||
| transaction.Put(table, item2, None) | ||
| transaction.Put(table, item3, Some existsCondition) | ||
| transaction.Delete (table ,table.Template.ExtractKey item5, None) | ||
|
|
||
| do! transaction.TransactWriteItems() | ||
| ``` | ||
|
|
||
| Failed preconditions (or `TransactWrite.Check`s) are signalled as per the underlying API: via a `TransactionCanceledException`. |
There was a problem hiding this comment.
Suggested change
| Failed preconditions (or `TransactWrite.Check`s) are signalled as per the underlying API: via a `TransactionCanceledException`. | |
| Failed preconditions (or `Check`s) are signalled as per the underlying API: via a `TransactionCanceledException`. |
bartelink
reviewed
Nov 9, 2024
README.md
Outdated
| @@ -269,25 +269,26 @@ let doesntExistCondition = compile <@ fun t -> NOT_EXISTS t.Value @> | |||
| let existsCondition = compile <@ fun t -> EXISTS t.Value @> | |||
| let key = TableKey.Combined(hashKey, rangeKey) | |||
|
|
|||
| let transaction = Transaction() | |||
| let transaction = table.CreateTransaction() | |||
|
|
|||
| transaction.Check(table, key, doesntExistCondition) | |||
| transaction.Put(table, item2, None) | |||
| transaction.Put(table, item3, Some existsCondition) | |||
| transaction.Delete (table ,table.Template.ExtractKey item5, None) | |||
There was a problem hiding this comment.
Suggested change
| transaction.Delete (table ,table.Template.ExtractKey item5, None) | |
| transaction.Delete(table, table.Template.ExtractKey item5, None) |
bartelink
reviewed
Nov 9, 2024
| @@ -1318,22 +1318,19 @@ type TableContext<'TRecord> | |||
| else | |||
| t.VerifyTableAsync() | |||
|
|
|||
| member t.Transaction() = | |||
| /// <summary>Creates a new `Transaction`, using the DynamoDB client and metricsCollector configured for this `TableContext`</summary> | |||
| member _.CreateTransaction() = | |||
| match metricsCollector with | |||
There was a problem hiding this comment.
Suggested change
| match metricsCollector with | |
| Transaction(client, ?metricsCollector = metricsCollector) |
bartelink
reviewed
Nov 9, 2024
| @@ -2151,7 +2137,7 @@ module Scripting = | |||
| t.UpdateTableIfRequiredAsync(spec) |> Async.Ignore |> Async.RunSynchronously | |||
|
|
|||
| /// Helpers for working with <c>TransactWriteItemsRequest</c> | |||
There was a problem hiding this comment.
Suggested change
| /// Helpers for working with <c>TransactWriteItemsRequest</c> | |
| /// Helpers for working with <c>Transaction</c> |
bartelink
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from #77