Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group by path endpoint and group members endpoint #146

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

p-weisk
Copy link

@p-weisk p-weisk commented Feb 14, 2025

Hi,
I came across the need to use the group by path and the group members endpoint. I mistakenly opened an issue for the group by path feature being missing from the all groups endpoint, since I overlooked the fact that it should be a separate endpoint.

Therefore, I created a pull request to implement the "GET /admin/realms/{realm}/groups/{group-id}/members" and the "GET /admin/realms/{realm}/group-by-path/{path}" endpoints.
Please let me know if there is anything I can improve on this pull request!

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 96.77%. Comparing base (3b6d4fe) to head (5ccb119).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
src/Resource/Groups.php 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   95.81%   96.77%   +0.95%     
==========================================
  Files          36       27       -9     
  Lines         861      837      -24     
==========================================
- Hits          825      810      -15     
+ Misses         36       27       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschmtt fschmtt self-requested a review February 14, 2025 06:26
@fschmtt
Copy link
Owner

fschmtt commented Feb 14, 2025

Hey, thank you for contributing! 🎉

Generally LGTM, could you please fix the code styling issues (composer ecs:fix) and if you don't mind add unit tests for the new endpoints? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants