Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github,setup,tox: drop support for Python<3.9 #34

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

tchaikov
Copy link
Collaborator

the CI is failing because we are using typing annotation like dict[str, Any]. and per https://devguide.python.org/versions/, Python 3.8 will be EOL in 2024-10. So let's stop support all versions lower than Python 3.9.

the CI is failing because we are using typing annotation like
`dict[str, Any]`. and per https://devguide.python.org/versions/,
Python 3.8 will be EOL in 2024-10. So let's stop support all
versions lower than Python 3.9.

Signed-off-by: Kefu Chai <[email protected]>
@tchaikov tchaikov added the cleanup Cleanups label Jul 24, 2024
@tchaikov tchaikov requested a review from fruch July 24, 2024 08:16
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.36%. Comparing base (205cd85) to head (5107654).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files           1        1           
  Lines         275      275           
=======================================
  Hits          254      254           
  Misses         21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fruch fruch merged commit 8b9f722 into fruch:master Jul 24, 2024
7 checks passed
@fruch
Copy link
Owner

fruch commented Jul 24, 2024

thanks for this one @tchaikov

@tchaikov tchaikov deleted the drop-support-for-python-3.8 branch July 24, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants