Add support of reporting subtest #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov @yarongilor, FYI |
fruch
force-pushed
the
add_support_for_subtests
branch
from
a583432
to
aa60f70
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 92.36% 92.47% +0.10%
==========================================
Files 1 1
Lines 275 279 +4
==========================================
+ Hits 254 258 +4
Misses 21 21 ☔ View full report in Codecov by Sentry. |
when one uses `pytest-subtests` plugin, this plugin was able to report only the last report from the test, which is passing always (if no setup/teardown issues, or failure outside of the context of subtests), and the subtest failure were lost and not counted/reported. this change is fixing this, and collects all of the reports during a test and report them each on it's own. this introduce a new field to the output of a test report, `subtest` if it's a report from subtest, it would be the message of that subtest. Fixes: #28
fruch
force-pushed
the
add_support_for_subtests
branch
from
aa60f70
to
5f4f6a9
Compare
|
@tchaikov what do you think about this one ? I do want to squeeze that in too, and make a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when one uses
pytest-subtestsplugin, this plugin was able to report only the last report from the test, which is passing always (if no setup/teardown issues, or failure outside of the context of subtests), and the subtest failure were lost and not counted/reported.this change is fixing this, and collects all of the reports during a test and report them each on it's own.
this introduce a new field to the output of a test report,
subtestif it's a report from subtest, it would be the message of that subtest.Fixes: #28