Skip to content

Commit

Permalink
fix: fixes a build issue in which it would not build when
Browse files Browse the repository at this point in the history
dlt-core jar wasn't build beforehand by declaring a dependency
from dlt-filter:jar to dlt-core:jar
  • Loading branch information
froks committed Mar 27, 2024
1 parent 754860b commit af6e00d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/build_with_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ permissions:

jobs:
build_and_test:
runs-on: ubuntu-latest

strategy:
matrix:
runs-on: [windows-latest, ubuntu-latest]
runs-on: ${{ matrix.runs-on }}
steps:
- uses: actions/checkout@v4
- name: Set up JDK
Expand All @@ -24,12 +26,12 @@ jobs:
uses: gradle/gradle-build-action@v3
- name: build and test
run: |
./gradlew build
./gradlew jar
./gradlew packageUberJarForCurrentOS
./gradlew packageUberJarForCurrentOS packageDistributionForCurrentOS
- name: upload artifact
uses: actions/upload-artifact@v4
with:
name: uber-jar
name: job-data-${{ matrix.runs-on }}
path: |
dlt-filter-app/build/compose/jars/dlt-filter*
dlt-filter-app/build/compose/binaries/**/*.deb
dlt-filter-app/build/compose/binaries/**/*.msi
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ jobs:
uses: gradle/gradle-build-action@v3
- name: build and test
run: |
./gradlew build
./gradlew jar
./gradlew packageDistributionForCurrentOS
- name: upload artifacts
uses: actions/upload-artifact@v4
Expand Down
4 changes: 4 additions & 0 deletions dlt-filter-app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ dependencies {
testImplementation("org.jetbrains.kotlin:kotlin-test")
}

tasks.named("jar") {
dependsOn(":dlt-core:jar")
}

tasks.test {
useJUnitPlatform()
}
Expand Down

0 comments on commit af6e00d

Please sign in to comment.