Possible 4.8 Flow for this module #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I dont get it, why someone added login = 1 to this function: 0b9f42c#diff-af8bcd88e358acfd9be4d37bc80a10b0 Maybe its required for something, but it wont working with detailpages, if user has no permission to login. |
Member
|
@Sioweb could you update this PR please? It also seems to contain a lot of unrelated changes. |
Author
|
I dont get it, what exactly do u need? What to update? |
Member
For example your PR contains changes to the formatting of the Also it is not quite clear to me what your PR actually does. Is it just a refactoring of the existing code into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
i've updated this module fo me, local and maybe u want to use it too, for contao 4.8 and newer - and maybe with a new major version.
The only real change from me is, Foc\Memberlist\Controller\FrontendModule\Memberlist line 198 - it will check related fields and return the related models.