Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PG::AmbiguousColumn if we do a join on 2 tables that has the same array_enum col name #19

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix PG::AmbiguousColumn if we do a join on 2 tables that has the same array_enum col name #19

merged 3 commits into from
Apr 11, 2024

Conversation

khaledm1990
Copy link
Contributor

@khaledm1990 khaledm1990 commented Apr 3, 2024 •
edited
Loading

The main purpose of this PR is to Fix the PG::AmbiguousColumn error when we do a join and filter on 2 tables that has the same array_enum col name

we also did the below

  1. Drop Ruby 2.7 support
  2. changed required Ruby version >= 3.0
  3. added test for Ruby 3.3
  4. update gems
  5. update GHA's version

@khaledm1990 khaledm1990 self-assigned this Apr 3, 2024
@khaledm1990 khaledm1990 force-pushed the fix-ambiguous-column-issue branch 2 times, most recently from 354b9de to 0388222 Compare April 3, 2024 13:48
@khaledm1990 khaledm1990 force-pushed the fix-ambiguous-column-issue branch from 0388222 to cb1619b Compare April 3, 2024 13:58
@khaledm1990 khaledm1990 merged commit 0565942 into master Apr 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoy-freeletics guoy-freeletics guoy-freeletics approved these changes

@gabrielittner gabrielittner gabrielittner approved these changes

Assignees

@khaledm1990 khaledm1990

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaledm1990 @gabrielittner @guoy-freeletics