add support for last_updated field in crosswalk generation #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
quevon24
approved these changes
Nov 7, 2024
| ) | ||
| except ValueError: | ||
| try: | ||
| self.updated_after = datetime.strptime( |
There was a problem hiding this comment.
maybe you can follow the same style and do this:
self.updated_after = options["updated_after"]
I think you can do this in one line, if something fails it will raise the ValueError exception:
self.updated_after = datetime.strptime(updated_after, "%Y-%m-%d").replace(tzinfo=pytz.UTC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the updated_after param that checks CAP data for a last_updated field. This will allow us to generate crosswalk files consisting of cases that have been updated after a given date. Dates should be in either format: YYYY-MM-DD or YYYY-MM-DDTHH:MM:SS+00:00.
Changes: