Bump linter tools versions an fix linter errors #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjeffman
force-pushed
the
ci_pin_ansible_lint_version
branch
4 times, most recently
from
c0ca824
to
5d7a28e
Compare
Bump version of ansible-lint, Flake8, Pylint and yamllint to newer versions as used in Ansible tests.
Github actions checkout v3.1.0 and setup-python v4.3.0 use deprecated Node.js 16. Bumping version to checkout v4.1.1 and setup-python v5.1.0 fixes the workflows, as both use the recommended Node.js 20. The checkout depth has been set to 1 (shallow copy) for all tasks that do not require git history to be available.
New versions of pylint ignore Python 2 functions and types, evaluating 'unicode' as "undefined". ansible-freeipa will always define 'unicode' when running under Python 3, and it is always defined under Python 2. This patch fixes these false positives.
pylint doesn't know that some functions may terminate execution, like, AnsibleModule's fail_json, and assume that, depending on the code path, some variables may not be initialized when used. This change ensure that variables are always initialized independent of the code path.
rjeffman
force-pushed
the
ci_pin_ansible_lint_version
branch
from
5d7a28e
to
52241fe
Compare
rjeffman
changed the title
rjeffman
force-pushed
the
ci_pin_ansible_lint_version
branch
from
3813ef5
to
77c1d20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use updated versions of the linter tools, Github actions, pre-commit hooks and fix some new warnings from pylint.