feat(api): add charge-stripe endpoint #54545
Conversation
github-actions
bot
added
the
platform: api
ahmaxed
changed the title
| if (user) req.user = user; | ||
| } | ||
| } catch { | ||
| return send401(reply, TOKEN_INVALID); |
There was a problem hiding this comment.
Not sure if I need to return an error or not here since we are just checking if user is authorized and pass the user object.
| }) | ||
| } | ||
| } | ||
| schema: schemas.addDonation |
| const { id: customerId } = await stripe.customers.create({ | ||
| email, | ||
| name | ||
| }); | ||
|
|
||
| // TODO(Post-MVP) stripe has moved to a paymentintent flow, the create call should be updated to reflect this | ||
| const paymentMethod = await stripe.paymentMethods.attach(token.id, { | ||
| customer: customerId | ||
| }); |
There was a problem hiding this comment.
In the current api, card has been passed directly when creating the customer. The current api works but the card definition has been removed from the ar types. As a result, I create the customer and then attach the payment method to it.
I will update current api to the new pattern as well.
| return reply.send({ | ||
| type: 'success', | ||
| isDonating: true |
There was a problem hiding this comment.
The current api returns the whole subscription, but that is not used in the client.
I returned isDonating for consistency.
| if ( | ||
| !isEmail(email) || | ||
| !donationSubscriptionConfig.plans[duration].includes(amount) | ||
| ) { |
There was a problem hiding this comment.
Improved the validation slightly to check existing for plan.
ahmaxed
added
the
status: waiting review
ShaunSHamilton
changed the title
| email, | ||
| name | ||
| }); | ||
|
|
There was a problem hiding this comment.
We should figure out if this might benefit from being done before creating the customer.
| const { id: paymentMethodId } = await stripe.paymentMethods.create({ | |
| type: 'card', | |
| card: { token: token.id } | |
| }); | |
ahmaxed
added
status: blocked
|
blocked by #54668 |
Checklist:
Update index.md)mainbranch of freeCodeCamp.Closes #51294