Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(curriculum): update grammar and tests in step 38 of music player #54543

Closed
wants to merge 4 commits into from
Closed

fix(curriculum): update grammar and tests in step 38 of music player #54543

wants to merge 4 commits into from

Conversation

Supravisor
Copy link
Contributor

Checklist:

Closes #53700

Code passes tests.
image

Hint when no code is entered.
image

Hint when the condition is undefined.
image

Hint when property is not set.
image

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Apr 26, 2024
jdwilkin4
jdwilkin4 reviewed Apr 27, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like anything was changed here

@jdwilkin4
Copy link
Contributor

This is what the current files changed tab looks like.

Screenshot 2024-04-27 at 10 18 49 AM

It is possible you forgot to push up a commit with your changes

@jdwilkin4 jdwilkin4 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP new javascript course These are for issues dealing with the new JS curriculum labels Apr 27, 2024
@Supravisor Supravisor closed this Apr 28, 2024
@Supravisor Supravisor deleted the music38 branch April 28, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 left review comments

Assignees
No one assigned
Labels
new javascript course These are for issues dealing with the new JS curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix grammar issues and update tests in step 38 of music player project
2 participants
@Supravisor @jdwilkin4