Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): clarify what progress reset includes #54542

Merged
merged 2 commits into from Apr 29, 2024

Conversation

huyenltnguyen
Copy link
Member

Checklist:

This PR updates the text in the progress reset modal to clarify what the action does.

Note: I'm not adding the big "WARNING!" text to the modal because it would bring inconsistency (the delete account modal doesn't have this text). We changed the reset modal to have its content displayed in danger color during the Modal migration, and I think this should suffice (we do communicate the critical level of the action through text, and not just text color, so this isn't an a11y concern).

Closes #53959

Screenshots

Before After
Screenshot 2024-04-26 at 15 43 12 Screenshot 2024-04-26 at 15 27 34

@github-actions github-actions bot added platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 26, 2024
@huyenltnguyen huyenltnguyen marked this pull request as ready for review April 26, 2024 15:14
@huyenltnguyen huyenltnguyen requested a review from a team as a code owner April 26, 2024 15:14
@naomi-lgbt naomi-lgbt enabled auto-merge (squash) April 26, 2024 15:32
@naomi-lgbt naomi-lgbt merged commit b38ef48 into freeCodeCamp:main Apr 29, 2024
19 of 22 checks passed
@huyenltnguyen huyenltnguyen deleted the fix/reset-modal branch May 2, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify Progress Reset Modal
3 participants