Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio timestamp for learn greetings task 7 #54486

Closed

Conversation

ojeytonwilliams
Copy link
Contributor

Checklist:

If you listen to https://www.freecodecamp.org/learn/a2-english-for-developers/learn-greetings-in-your-first-day-at-the-office/task-7 you can just hear the start of the next sentence. This should fix that.

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Apr 22, 2024
@moT01 moT01 added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Apr 22, 2024
@moT01
Copy link
Member

moT01 commented Apr 22, 2024

While reviewing this, I noticed quite a few where the dialogue wasn't synced with the text. e.g. the audio cut off early or late. Some were quite significant. I want to look into it before we start adjusting all the timestamps, cause the problem could be elsewhere and the timestamps might be correct as they are.

@ojeytonwilliams
Copy link
Contributor Author

Yep, that's fair. It seemed fairly consistent for me, but I spoke to Daniel and apparently that's not typical.

@ojeytonwilliams
Copy link
Contributor Author

As Tom said

problem could be elsewhere and the timestamps might be correct as they are.

So I'm closing as we (mostly Tom) are working on a general solution.

@ojeytonwilliams ojeytonwilliams deleted the fix/audio-timestamp branch April 23, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants