Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove api mocks from link ms user spec #54482

Merged

Conversation

ojeytonwilliams
Copy link
Contributor

@ojeytonwilliams ojeytonwilliams commented Apr 22, 2024

  • test: seed the ms username to avoid mocking

Checklist:

Rather than mocking the server's response, this modifies the db so that the api responds correctly.

This makes the e2e tests actually e2e tests as well as making them more useful for the api migration. i.e. if the migration breaks one of the routes and that route was mocked we wouldn't know.

@ojeytonwilliams ojeytonwilliams requested a review from a team as a code owner April 22, 2024 11:16
@github-actions github-actions bot added the scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. label Apr 22, 2024
@ojeytonwilliams ojeytonwilliams changed the title test: remove api mocks from e2e tests test: remove api mocks from link ms user spec Apr 23, 2024
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have to use a regex here, we should probably escape the wildcards just to be safe.

e2e/link-ms-user.spec.ts Outdated Show resolved Hide resolved
@ojeytonwilliams ojeytonwilliams added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Apr 24, 2024
@ojeytonwilliams
Copy link
Contributor Author

This will fail until #54518 is merged, so I've blocked it for now.

@ojeytonwilliams ojeytonwilliams added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. labels May 3, 2024
@huyenltnguyen huyenltnguyen merged commit 7214c2e into freeCodeCamp:main May 3, 2024
21 checks passed
@ojeytonwilliams ojeytonwilliams deleted the test/no-api-mocks-in-e2e branch May 3, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts Scripts for supporting dev work, generating config and build artifacts, etc. status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants