Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add English curriculum block 9.2 requesting and receiving guidance from others #54480

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): add English curriculum block 9.2 requesting and receiving guidance from others #54480

wants to merge 6 commits into from

Conversation

miyaliu666
Copy link
Member

Checklist:

@miyaliu666 miyaliu666 requested a review from a team as a code owner April 22, 2024 08:43
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 22, 2024
@miyaliu666 miyaliu666 added new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label and removed scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 22, 2024
@miyaliu666
Copy link
Member Author

I don't see why task-46 doesn't show "description" when running locally.

naomi-lgbt
naomi-lgbt requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit

...english-for-developers/learn-how-to-request-and-receive-guidance/6625d0e9ef6f966c3e2d6164.md Outdated Show resolved Hide resolved
@naomi-lgbt naomi-lgbt added the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt requested changes

@nieldakarla nieldakarla Awaiting requested review from nieldakarla

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miyaliu666 @naomi-lgbt