Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curriculum): add animations to block 4.2 of the English Curriculum #54415

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): add animations to block 4.2 of the English Curriculum #54415

wants to merge 8 commits into from

Conversation

DanielRosa74
Copy link
Contributor

Checklist:

@DanielRosa74 DanielRosa74 requested a review from a team as a code owner April 16, 2024 23:17
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 16, 2024
@nieldakarla nieldakarla self-assigned this Apr 22, 2024
@nieldakarla nieldakarla added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. new english course English Curriculum labels Apr 22, 2024
naomi-lgbt
naomi-lgbt requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests need to be updated to accept the new scenes.

@naomi-lgbt naomi-lgbt added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naomi-lgbt naomi-lgbt naomi-lgbt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nieldakarla nieldakarla

Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielRosa74 @naomi-lgbt @nieldakarla