Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add project block for basic functions The Odin Project #54375

Merged
merged 9 commits into from May 2, 2024
Merged

feat: add project block for basic functions The Odin Project #54375

merged 9 commits into from May 2, 2024

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Apr 12, 2024 •
edited

Checklist:

Closes #XXXXX

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 12, 2024
@Sembauke Sembauke mentioned this pull request Apr 16, 2024
Draft
4 tasks
@Sembauke Sembauke marked this pull request as ready for review April 16, 2024 12:44
@Sembauke Sembauke requested a review from a team as a code owner April 16, 2024 12:44
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 16, 2024
jdwilkin4
jdwilkin4 reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it locally and it looks good.
left some comments 👍

...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-a.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-a.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-a.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-b.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-b.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-c.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-c.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-d.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-d.md Outdated Show resolved Hide resolved
...es/english/16-the-odin-project/top-basic-function-projects/top-basic-functions-exercise-d.md Outdated Show resolved Hide resolved
@Sembauke Sembauke marked this pull request as draft April 17, 2024 18:53
@Sembauke Sembauke removed the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 17, 2024
@Sembauke Sembauke marked this pull request as ready for review April 18, 2024 06:39
@Sembauke Sembauke requested a review from jdwilkin4 April 18, 2024 06:39
@Sembauke Sembauke added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 18, 2024
naomi-lgbt
naomi-lgbt requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@naomi-lgbt naomi-lgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the feedback from our JS course, I wonder if we should use these review exercises in a similar way.

That is, test only the function's returned value, and let the camper implement that however they see fit?

@naomi-lgbt naomi-lgbt added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 25, 2024
@Sembauke
Copy link
Member Author

Sembauke commented Apr 29, 2024 •
edited

That was my original intent before @jdwilkin4 review @naomi-lgbt 😄

Jessica what do you think about it?

@jdwilkin4
Copy link
Contributor

@Sembauke

but we already are testing for the final return value.

@Sembauke
Copy link
Member Author

Sembauke commented May 2, 2024

@naomi-lgbt Can you give this another look?

@naomi-lgbt naomi-lgbt merged commit 7090307 into freeCodeCamp:main May 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

@naomi-lgbt naomi-lgbt naomi-lgbt approved these changes

Assignees
No one assigned
Labels
platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sembauke @jdwilkin4 @naomi-lgbt