Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(curriculum): add English curriculum block 8.2 updates and plans on tasks or projects #54332

Merged
merged 5 commits into from May 7, 2024

Conversation

miyaliu666
Copy link
Member

Checklist:

@miyaliu666 miyaliu666 requested a review from a team as a code owner April 9, 2024 05:36
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label labels Apr 9, 2024
@miyaliu666 miyaliu666 added the new english course English Curriculum label Apr 9, 2024
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind @miyaliu666, I pushed some minor fixes. Take a look at the diff to see what I changed, or let me know if you want me to show you.

This looks good. The only concern I had is that the first two task descriptions are the "Practice time" style. Do we want to start with two tasks that don't explain anything and just throw users into it? I'm fine with it, just mentioning it.

@miyaliu666
Copy link
Member Author

@naomi-lgbt I used "Fill in the blanks in the dialogue below" and "Please answer the question below" in Part 9 and 5 after I saw your comments here.

I'll add explanations for words in the first two tasks as @moT01 pointed out. Those words have been taught in previous blocks, but we can review them here because people may not learn the blocks in strict order.

Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@moT01 moT01 requested a review from naomi-lgbt May 7, 2024 13:37
@moT01 moT01 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label May 7, 2024
@naomi-lgbt naomi-lgbt merged commit 7b01779 into freeCodeCamp:main May 7, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new english course English Curriculum scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants