Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing yii scraper - the url scheme for the api docs changed (with everything else staying the same) #2267

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

HayateLaTech
Copy link

If you're updating existing documentation to its latest version, please ensure that you have:

  • Updated the versions and releases in the scraper file
  • Ensured the license is up-to-date
  • Ensured the icons and the SOURCE file in public/icons/your_scraper_name/ are up-to-date if the documentation has a custom icon
  • Ensured self.links contains up-to-date urls if self.links is defined
  • Tested the changes locally to ensure:
    • The scraper still works without errors
    • The scraped documentation still looks consistent with the rest of DevDocs
    • The categorization of entries is still good

@HayateLaTech HayateLaTech requested a review from a team as a code owner June 17, 2024 22:04
Copy link
Contributor

@simon04 simon04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs some more adaptions: The categories changed drastically. The guides are gone. The "x followers" on top of every pages needs to be removed.

devdocs io_yii_
localhost_9292_yii~2 0_

@HayateLaTech
Copy link
Author

I'll try to fix it! 😊💕

@HayateLaTech HayateLaTech marked this pull request as draft June 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants