Avoid showing analitics notification more than once #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon04
reviewed
Jun 24, 2021
Comment on lines
212
to
213
| # Only ask for consent once per browser session | ||
| Cookies.set('analyticsConsentAsked', '1') |
There was a problem hiding this comment.
How does your change relate to those two lines? You to tackle the same problem.
There was a problem hiding this comment.
This line avoids show me more than once the analitics consent when cookies are enabled, In my case I do not accept neither the devdocs cookie nor the analitics, thus this line does not fix the problem.
assets/javascripts/app/app.coffee
Outdated
| @@ -11,6 +11,7 @@ | |||
| try @initErrorTracking() catch | |||
| return unless @browserCheck() | |||
|
|
|||
| @showAnaliticsOne = false | |||
There was a problem hiding this comment.
Should this be analiticsAlreadyShown?
There was a problem hiding this comment.
Fixed, should be fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I usually do not accept cookies in any website and I didn't accept cookies in Devdocs. Devdocs can be really intrusive to show a notifications telling me to accept analytics each time I click a page, this is a silly behavior so I change it to only show one time the analytics notification during each Devdocs session.
I also notice that the cookies and the analytics notifications didn't hide automatically thus I added two seconds to hide them automatically.
Look at the following image showing the notifications generated by devdocs when I did not accept the cookies:
