Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use vite testing #315

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Sep 12, 2024

Checklist:

Closes #301

It's a pretty huge migration but it adds both Typescript to the main files and Vite.

Copy link

socket-security bot commented Sep 12, 2024

@shootermv
Copy link

@a2937 are you still working on this PR? i wanted to ask something if you do...

@a2937
Copy link
Member Author

a2937 commented Oct 29, 2024

@shootermv

What's the question?

Edit: I had gotten stuck on this PR due to Netlify issues. I am not abandoning this PR. I just think I need a little help.

@shootermv
Copy link

shootermv commented Oct 29, 2024 via email

@shootermv
Copy link

shootermv commented Oct 29, 2024 via email

@a2937 a2937 force-pushed the feat/use-vite-testing branch 2 times, most recently from 57a7c42 to bacd2a1 Compare October 29, 2024 13:23
@a2937
Copy link
Member Author

a2937 commented Oct 29, 2024

How about also move from using create-react-app and move to use vite instead?

Except I did. I also needed Typescript. The netlify issues were updating the header rules and dealing the pages changed thing.

P.S Sorry about the next few pushes. The package.json is taking me by surprise.

vite.config.ts Outdated Show resolved Hide resolved
@shootermv
Copy link

i can see something is wrong with cypress test for firefox - is running without finish

@a2937
Copy link
Member Author

a2937 commented Oct 29, 2024

Remind me to update this to use Playwright after this PR gets merged.

@shootermv
Copy link

i think i have idea about solve "endless cypress run" issue...
how about to run the cypress only on chrome?
you can use --browser flag cypress run --browser chrome
i know i is not ideal solution, to ignore ff, but anyway , the plan is to move to playwright...

@a2937
Copy link
Member Author

a2937 commented Nov 1, 2024

I have a crazy idea but I think I know why it's continuing forever. It's trying to load in the ChatBot that is linked to the Discord server.

@shootermv
Copy link

i changed the cypress command at package json "scripts" to cypress run --browser chrome & tested locally. it worked at my environment...
also it may be good idea to upgrade cypress to ^13.15.1 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider move the dev server to vite from deprecated CRA
3 participants