-
-
Notifications
You must be signed in to change notification settings - Fork 111
feat: add resume builder workshop #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
fullstack-cert/typescript-projects/resume-builder/src/Field.tsx
Outdated
Show resolved
Hide resolved
fullstack-cert/typescript-projects/resume-builder/src/components/CVPreview.tsx
Outdated
Show resolved
Hide resolved
question: why not to use |
Because I couldn't figure out how to add it with CDN.js AND get all the types to work. |
let me understand, you cannot use |
There're grounds for FCC to take this approach. Under the assumption that they use this approach for all of their external libraries (I don't know that they do, just justifying the extreme case), there have been multiple incidents in the past where npm has been a delivery device for exploits, across various packages. By storing approved versions of packages on your own CDN you help to protect against this form of attack. It also protects from the pettier issues, like when a particular javascript library was removed from npm and broke all dependent libraries. When stored on an internal CDN you know the version you're using is guaranteed to stick around. The |
Let's scrap lucide and use font awesome instead - those are readily available at https://cdnjs.com/libraries/font-awesome |
- Corrected margin right for calendar icons in the resume preview.
better fall in line with the current approach.
- Corrected trash bin colors
Resume builder/remove lucide
refactor: remove tailwindcss from dependencies and add link to cdn
feat: add preview toggle to support a mobile
Checklist:
Update index.md
)Closes #645
Replaces #943